Skip to content

allow creating ldap accounts after linking accounts to the same the d… - #13945

Open
DaanHoogland wants to merge 3 commits into
4.20from
ghi8732-ldap-createaccount-group-scope
Open

allow creating ldap accounts after linking accounts to the same the d…#13945
DaanHoogland wants to merge 3 commits into
4.20from
ghi8732-ldap-createaccount-group-scope

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

…omain

Description

This PR...

Fixes: #8732

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.20.4 milestone Aug 21, 2026
@DaanHoogland DaanHoogland linked an issue Aug 21, 2026 that may be closed by this pull request
Unable to create another ldap Account if another account is linked to ldap group in the same domain #8732
Open
@github-project-automation github-project-automation Bot moved this to Backlog in Testing Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.14%. Comparing base (6136ac9) to head (00e3223).

❗ There is a different number of reports uploaded between BASE (6136ac9) and HEAD (00e3223). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6136ac9) HEAD (00e3223)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.20   #13945       +/-   ##
=============================================
- Coverage     16.32%    4.14%   -12.18%     
=============================================
  Files          5669      405     -5264     
  Lines        501399    33026   -468373     
  Branches      60902     5898    -55004     
=============================================
- Hits          81847     1370    -80477     
+ Misses       410390    31480   -378910     
+ Partials       9162      176     -8986
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
43.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component:LDAP

Projects

Testing
Status: Backlog

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

Unable to create another ldap Account if another account is linked to ldap group in the same domain

1 participant

@DaanHoogland